Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly register custom open-url evt handling #20518

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Oct 10, 2019

Description of Change

Fixes #20181.

When we removed our use of MainMenu.xib in this chromium roll commit, we inadvertently made it such that awakeFromNib defined in atom_application.mm was no longer called, and as such our custom handler for urls would no longer be registered and fired.

This fixes that issue by moving the url registration logic into a new method registerURLHandler() and ensuring that it's called in PreMainMessageLoopStartCommon(), at the same point in startup flow where this logic was previously being invoked.

cc @MarshallOfSound @jkleinsc @nornagon

Checklist

Release Notes

Notes: Fixed an issue where the open-url event was not properly being fired on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 10, 2019
@MarshallOfSound MarshallOfSound merged commit 812de5d into master Oct 10, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 10, 2019

Release Notes Persisted

Fixed an issue where the open-url event was not properly being fired on macOS.

@trop
Copy link
Contributor

trop bot commented Oct 10, 2019

I have automatically backported this PR to "7-0-x", please check out #20523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The open-url Event doesn't fire anymore
5 participants