fix: properly register custom open-url evt handling #20518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #20181.
When we removed our use of
MainMenu.xib
in this chromium roll commit, we inadvertently made it such thatawakeFromNib
defined inatom_application.mm
was no longer called, and as such our custom handler for urls would no longer be registered and fired.This fixes that issue by moving the url registration logic into a new method
registerURLHandler()
and ensuring that it's called inPreMainMessageLoopStartCommon()
, at the same point in startup flow where this logic was previously being invoked.cc @MarshallOfSound @jkleinsc @nornagon
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where the
open-url
event was not properly being fired on macOS.